Replace lodash-es with es-toolkit
#17496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
previously approved these changes
Nov 20, 2024
|
TBH, this is the first time I heard we keep lodash... I thought it's 1:1 replacement, and having two libs makes less sense for me. R- from me, as it's increasing dependencies count w/o discussing this openly. And what are potential workarounds for this. |
|
We've decided to put this on hold until I'll also contribute to the |
Co-authored-by: Szymon Cofalik <s.cofalik@cksource.com>
Fix (engine): The link `rel` attribute will now allow mixing manual link decorators for the same attribute, as it will be now handled as a token list. Closes #13985, closes #6436. Fix (mention): Mention should not be wrapped with an additional `<span>` when GHS is enabled. Closes #15329. Internal (html-support): Attribute matching updated to the new output of `Matcher#matchAll()`. MINOR BREAKING CHANGE (engine): The `ViewConsumable.consumablesFromElement()` is removed and replaced with `view.Element#_getConsumables()` internal method. You should use `ViewConsumable.createFrom()` To create consumables if needed. MINOR BREAKING CHANGE (engine): The `ViewElementConsumables` now accepts and outputs only normalized data. The `ViewConsumable` still accepts normalized or non-normalized input. MINOR BREAKING CHANGE (engine): The `Matcher#match()` and `Matcher#matchAll()` output is now normalized. The `MatchResult#match` now contains normalized data compatible with changes in the `ViewConsumable`.
Internal: Fixed invalid links in docs snippets.
filipsobol
force-pushed
the
replace-lodash-es-with-es-toolkit
branch
from
f3ed2e4 to
ef1a008
Compare
|
The work will continue in #17872. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Replace
lodash-eswithes-toolkit.You can find more information about why we make this change here: #16395 (comment)